Site Feedback, Please!, Can I have your feedback on my site?

[cgrady]

Dear All,

I was wondering if you could give me some feedback on my site that is currently under construction and in the Alpha Phase of development. I created using Dreamweaver CS4, if you recommend something better or just using Notepad or something, please let me know. As you can see I'm still learning HTML and CSS, so bear with me please. My site is at connorgradyfiles.uuuq.com/gen5/.

Thanks in advance!

[MrTouz]

Well :

Layout : It is really basic and there is pretty much to review. No graphics at all, the font used are not really 'nice' the colors do not match and the green is to bright to be able to read the nav's text.

Coding : i do not know if you coded this layout by yourself because there are things that are advanced and some that are really stupid.
For example, you are using divs only... no tables... usually 'good' coders use divs because it's nicer but 'kind of' harder... so we might think your a good coder because you use divs... but when we look at your CSS... omg... what's going on my friend ? same with your javascript.

Changes : For the layout ? pretty much colors, css for fonts, and hovers....

For the coding part... :

Regroup all your CSS in ONE and only ONE file. It's not like you are using 2 different documents because one is for the main site and one for an 'extra app' you have...

You opened the link for css twice :

CODE

<link href="SpryMenuBarVertical.css" rel="stylesheet" type="text/css" />
<link href="connorgradygentemplate.css" rel="stylesheet" type="text/css" />

You opened the style tag to include css twice :

CODE

<!--[if IE]>
<style type="text/css">
/* place css fixes for all versions of IE in this conditional comment */
.twoColLiqLtHdr #sidebar1 { padding-top: 30px; }
.twoColLiqLtHdr #mainContent { zoom: 1; padding-top: 15px; }
/* the above proprietary zoom property gives IE the hasLayout it needs to avoid several bugs */
</style>
<![endif]-->
<style type="text/css">
<!--
.ConnorGradybackground {
    color: #7D848E;
}
-->
</style>

Now you might say but how do i tell IE... change your navigation... there are ones that work on Internet explorer, opera, firefox, safari, google chrome and all that in all the versions... so no need to have a headache with one that only works here and there...

As for your Javascript... it's the same. I understand having a doc by it self for the menu but these two :

CODE

<script type="text/javascript">
var gaJsHost = (("https:" == document.location.protocol) ? "https://ssl." : "http://www.");
document.write(unescape("%3Cscript src='" + gaJsHost + "google-analytics.com/ga.js' type='text/javascript'%3E%3C/script%3E"));
</script>
<script type="text/javascript">
try {
var pageTracker = _gat._getTracker("UA-7601820-1");
pageTracker._trackPageview();
} catch(err) {}</script>

They can be put in ONE document. That will light up your page... instead of displaying 50 lines of codes just display 2.

Also your website is not valid xHTML 1.0... you have 3 errors.

I don't understand.

[cgrady]

Dear MrTouz,

Thanks a lot for you feedback. As you can see I'm still learning. I used Dreamweaver CS4 to create the pages so one of the things you pointed out to me was created completely by Dreamweaver, not by me. But I do understand what your telling me about the CSS. I have extremely limited knowledge of CSS but I'm learning from a friend of mine. Maybe you heard of him, Connor Zwick. I don't know, anyway I will work on the layout and the color scheme, and the CSS.

Thanks!

[Robdale]

MrTouz have already told everything. Just concentrate on those points.